Feature: EmfMetricLoggingPublisher #5792
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* EmfMetricPublisher class with basic unit test added * Edge cases handled * javadoc for class added * Java doc for methods added * minor unit test changes * Change from using jacksonCore directly to using jsonWriter * EmfMetricConfiguration class added * MetricEmfConverter class added * new module checklist done * checkStyle fixed * minor build problem fixed * internal package added * fixed the issue passing raw objects * added java clock to unit test * added unit test for publish method * minor changes * config class to builder pattern * config class to builder pattern * minor change * End to end test passed * added valid case in WARN_LOG allowlist * unit tests adjusted * Change logGroupName to required field * move MetricValueNormalizer class to utils package * converter implementation changed * schemaConformTest added * SchemaConformTest adjusted * minor change
* Benchmark test for emfMetricPublisher added * input name changed * add emfBenchmarkTest to BenchmarkRunner * enabled METRIC_BENCHMARKS * checkStyle fixed
* change class name and artifactId * test-coverage pom changed * javadoc fixed
…nfig (#5790) * more benchmark test added/changed logGroupName config * teardown method overrided * logGroupName access method changed * Snapshot version changed * LogGroupName in lambda unit test added * suppression added for system
…aws-sdk-java-v2 into feature/master/emf-metric-publisher
joviegas
reviewed
Jan 16, 2025
| <parent> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>metric-publishers</artifactId> | ||
| <version>2.30.2-SNAPSHOT</version> |
There was a problem hiding this comment.
I think this will get updated again after todays and tomorrows release (latest one)
Please make sure we update this before the actual release day
joviegas
approved these changes
Jan 16, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
. The CloudWatch Embedded Metric Format (EMF) offers a more suitable approach for Lambda environments as well as other execution environment that has built-in integration with cloudwatch logs. EmfMetricLoggingPublisher uses Jackson-Core and convert SDK metric collections into EMF-formatted log entries.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License