Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InternalApiBoundaryTest to skip flagging the use of protected APIs that are in internal package #5774

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jan 6, 2025

Motivation and Context

  • Update InternalApiBoundaryTest to skip flagging the use of protected APIs that are in internal package because those APIs should already be flagged and given exceptions in PackageContainmentTest

  • Mark NullJsonNode as protected API because it's already used in other modules.

@zoewangg zoewangg requested a review from a team as a code owner January 6, 2025 22:52
@zoewangg zoewangg force-pushed the zoewang/improveTests branch from 5fbb39c to 3e55819 Compare January 6, 2025 22:53
@zoewangg zoewangg force-pushed the zoewang/improveTests branch from b23f1c6 to cf6cdb1 Compare January 16, 2025 00:12
@zoewangg zoewangg enabled auto-merge January 16, 2025 00:12
@zoewangg zoewangg added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@zoewangg zoewangg enabled auto-merge January 16, 2025 22:43
@zoewangg zoewangg added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@zoewangg zoewangg force-pushed the zoewang/improveTests branch from c5abe5e to a414d76 Compare March 4, 2025 19:15
Copy link

sonarqubecloud bot commented Mar 4, 2025

@zoewangg zoewangg added this pull request to the merge queue Mar 4, 2025
Merged via the queue into master with commit 25d5a40 Mar 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants