feat: custom endpoint support #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
feat/custom-endpoints
branch
2 times, most recently
from
098d646 to
1dbd66a
Compare
karenc-bq
commented
Jan 10, 2025
karenc-bq
commented
Jan 10, 2025
ColinKYuen
reviewed
Jan 10, 2025
jkwuc89
reviewed
Jan 13, 2025
Will add the tests in this PR as well |
karenc-bq
changed the title
karenc-bq
added
ready for review
karenc-bq
force-pushed
the
feat/custom-endpoints
branch
13 times, most recently
from
77c9341 to
290d4d7
Compare
karenc-bq
force-pushed
the
feat/custom-endpoints
branch
2 times, most recently
from
3b61688 to
bd0e989
Compare
karenc-bq
force-pushed
the
feat/custom-endpoints
branch
3 times, most recently
from
49e54de to
2abe8b3
Compare
karenc-bq
force-pushed
the
feat/custom-endpoints
branch
from
2abe8b3 to
304c093
Compare
karenc-bq
commented
Jan 27, 2025
| Aws::RDS::Model::DescribeDBClusterEndpointsRequest request; | ||
| request.SetDBClusterEndpointIdentifier(this->endpoint_identifier); | ||
| // TODO: Investigate why filters returns `InvalidParameterCombination` error saying filter values are null. | ||
| // request.AddFilters(filter); |
There was a problem hiding this comment.
Will uncomment this once this fix is released on aws-sdk-cpp: aws/aws-sdk-cpp#3264
ColinKYuen
reviewed
Jan 27, 2025
jkwuc89
reviewed
Jan 28, 2025
| const std::string& custom_endpoint_host, | ||
| const std::string& endpoint_identifier, const std::string& region, | ||
| long long refresh_rate_nanos, ctpl::thread_pool& thread_pool, | ||
| bool enable_logging, std::shared_ptr<Aws::RDS::RDSClient> client) |
There was a problem hiding this comment.
I see that you added the client parameter to this version of the constructor but I don't see it being used in any of the initializers below. How is this used?
There was a problem hiding this comment.
This is used in the unit test
jkwuc89
reviewed
Jan 28, 2025
jkwuc89
reviewed
Jan 28, 2025
jkwuc89
reviewed
Jan 28, 2025
jkwuc89
reviewed
Jan 28, 2025
jkwuc89
reviewed
Jan 28, 2025
driver/topology_service.cc
Outdated
Comment on lines
195
to
210
| if (allowed_list.size() > 0) { | ||
| for (const auto& host : topology->get_instances()) { | ||
| if (allowed_list.find(host->get_host_id()) != allowed_list.end()) { | ||
| filtered_topology->add_host(host); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (blocked_list.size() > 0) { | ||
| for (const auto& host : filtered_topology->get_instances()) { | ||
| // Remove blocked hosts from the filtered_topology. | ||
| if (blocked_list.find(host->get_host_id()) != blocked_list.end()) { | ||
| filtered_topology->remove_host(host); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Given that calling find on an empty list will always return end(), I think this block can be simplified as follows which eliminates traversing filtered_topology->get_instances() twice.
for (const auto& host : topology->get_instances()) {
if (allowed_list.find(host->get_host_id()) != allowed_list.end()) {
filtered_topology->add_host(host);
}
if (blocked_list.find(host->get_host_id()) != blocked_list.end()) {
filtered_topology->remove_host(host);
}
}
jkwuc89
reviewed
Jan 28, 2025
karenc-bq
force-pushed
the
feat/custom-endpoints
branch
from
6b803c9 to
da3e366
Compare
ColinKYuen
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for RDS custom endpoints.
GUI:
Description
Review Status
Additional Reviewers