Add CMAC benchmark for AWS-LC #2218
Open
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2218 +/- ##
==========================================
- Coverage 79.08% 79.06% -0.03%
==========================================
Files 612 612
Lines 106327 106327
Branches 15023 15021 -2
==========================================
- Hits 84088 84064 -24
- Misses 21588 21612 +24
Partials 651 651 ☔ View full report in Codecov by Sentry. |
smittals2
reviewed
Feb 25, 2025
| @@ -34,6 +34,8 @@ | |||
| #include "internal.h" | |||
|
|
|||
| #include <openssl/crypto.h> | |||
|
|
|||
smittals2
approved these changes
Feb 25, 2025
|
|
||
| return | ||
| #if defined(OPENSSL_IS_AWSLC) || defined(OPENSSL_IS_BORINGSSL) | ||
| CMAC_Reset(ctx.get()) && |
There was a problem hiding this comment.
Just checking the reset call is enough for LC, we don't need an init on top of this?
There was a problem hiding this comment.
Correct, reset is a AWS-LC/BroingSSL helper function https://github.com/aws/aws-lc/blob/main/include/openssl/cmac.h#L64 that keeps the key but resets the state so a new message can be authenticated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a benchmark for CMAC, OpenSSL 1.0.2 does not support CMAC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.