Clang format #2211
Draft
Clang format #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
force-pushed
the
clang_format
branch
7 times, most recently
from
0e13499 to
5afa0ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
==========================================
- Coverage 79.06% 79.05% -0.02%
==========================================
Files 611 611
Lines 106351 106352 +1
Branches 15038 15038
==========================================
- Hits 84085 84074 -11
- Misses 21615 21625 +10
- Partials 651 653 +2 ☔ View full report in Codecov by Sentry. |
|
@andrewhop Is it possible to have sub-trees use a separate |
andrewhop
force-pushed
the
clang_format
branch
from
f6805ce to
dadd448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR has 3 commits that each do one thing:
Callouts:
Why clang-format-17? Clang 18.1.* had breaking changes between releases and the version in GitHub runners is not the latest 18 release. This is an annoying developer setup because on Mac brew wants to install the latest version which has different opinions on code styling. For now the latest clang-format 17 is easily available in GitHub runners and brew. The actual difference between them is quite small.
https://github.com/actions/runner-images/blob/ubuntu24/20250209.1/images/ubuntu/Ubuntu2404-Readme.md
Testing:
There is a new CI test that ensures no formatting issues are introduced and if we update the .clag-format file they are applied
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.