Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SSL to inherit ciphersuites from SSL_CTX at initialization #2198

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

smittals2
Copy link
Contributor

Description of changes:

This is a follow up to 154f998.
These changes initialize the SSL object with configured ciphersuites from the parent SSL_CTX object at initialization. Now both SSL and SSL_CTX objects will have their own copy of ciphersuites.

We inherited the behavior of defaulting to SSL_CTX ciphersuites when none are set on SSL from BoringSSL. OpenSSL does things differently and copies the ciphersuites to SSL at init. This behavioral difference is aligned in this PR.

Testing:

A test to ensure changes to SSL_CTX don't impact SSL configurations and we correctly inherit ciphersuites.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner February 17, 2025 08:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (154f998) to head (f39d777).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2198   +/-   ##
=======================================
  Coverage   79.05%   79.06%           
=======================================
  Files         612      612           
  Lines      106159   106242   +83     
  Branches    15002    15010    +8     
=======================================
+ Hits        83923    83997   +74     
- Misses      21582    21594   +12     
+ Partials      654      651    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

torben-hansen
torben-hansen previously approved these changes Feb 17, 2025
torben-hansen
torben-hansen previously approved these changes Feb 18, 2025
torben-hansen
torben-hansen previously approved these changes Feb 19, 2025
@smittals2 smittals2 merged commit acdf53b into aws:main Feb 20, 2025
117 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants