-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify SSL to inherit ciphersuites from SSL_CTX at initialization #2198
Merged
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2198 +/- ##
=======================================
Coverage 79.05% 79.06%
=======================================
Files 612 612
Lines 106159 106242 +83
Branches 15002 15010 +8
=======================================
+ Hits 83923 83997 +74
- Misses 21582 21594 +12
+ Partials 654 651 -3 ☔ View full report in Codecov by Sentry. |
torben-hansen
previously approved these changes
Feb 17, 2025
torben-hansen
previously approved these changes
Feb 18, 2025
andrewhop
reviewed
Feb 19, 2025
torben-hansen
previously approved these changes
Feb 19, 2025
torben-hansen
approved these changes
Feb 20, 2025
andrewhop
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a follow up to 154f998.
These changes initialize the SSL object with configured ciphersuites from the parent SSL_CTX object at initialization. Now both SSL and SSL_CTX objects will have their own copy of ciphersuites.
We inherited the behavior of defaulting to SSL_CTX ciphersuites when none are set on SSL from BoringSSL. OpenSSL does things differently and copies the ciphersuites to SSL at init. This behavioral difference is aligned in this PR.
Testing:
A test to ensure changes to SSL_CTX don't impact SSL configurations and we correctly inherit ciphersuites.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.