Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] aws-lc-sys: avoid building unnecessary source files #711

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 26, 2025

Description of changes:

  • Avoid compiling AWS-LC source files not needed by aws-lc-rs.
  • Reduces build latency of aws-lc-sys by between 20-40%.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (c358484) to head (3e52303).
Report is 184 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   95.80%   92.86%   -2.94%     
==========================================
  Files          61       70       +9     
  Lines        8143     9559    +1416     
  Branches        0     9559    +9559     
==========================================
+ Hits         7801     8877    +1076     
- Misses        342      413      +71     
- Partials        0      269     +269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the build-latency branch 2 times, most recently from 088a4cd to 64bc4ff Compare March 11, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants