Request response workspace #612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
reviewed
Feb 28, 2025
| public class V2DeserializationFailureEvent { | ||
| private Throwable cause; | ||
| private byte[] payload; | ||
| // when topic is available, add it |
There was a problem hiding this comment.
Trivial: Should this comment be labeled as a TODO? Or removed?
sbSteveK
reviewed
Feb 28, 2025
| import software.amazon.awssdk.iot.iotshadow.model.*; | ||
|
|
||
| /** | ||
| * The AWS IoT Device Shadow service adds shadows to AWS IoT thing objects. Shadows are a simple data store for device properties and state. Shadows can make a device’s state available to apps and other services whether the device is connected to AWS IoT or not. |
There was a problem hiding this comment.
Trivial: "Shadows can make a device's [last reported] state available to apps and other services whether the device is [currently] connected to AWS IoT or not" ?
sbSteveK
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.