chore: make EncodeAscii ghost #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Below` function is in the hot path. The slice (x[1..]) operation is not optimized in Dafny. This optimizes this function by turning the recursive slice into a loop over an index into the seq. Further, a bounded integer version is also included.
The `MergeSort` function is in the hot path. The slice (x[1..]) operation is not optimized in Dafny. This optimizes this function by turning the recursive slice into a loop over an index into the seq. Further, a bounded integer version is also included. It also limits the total amount of data copied.
texastony
reviewed
Mar 24, 2025
DynamoDbEncryption/dafny/DynamoDbEncryption/test/DynamoDbGetEncryptedDataKeyDescriptionTest.dfy
Outdated
Show resolved
Hide resolved
DynamoDbEncryption/dafny/DynamoDbEncryption/test/DynamoDbGetEncryptedDataKeyDescriptionTest.dfy
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Return the sum of the sizes of the given fields | ||
| function method {:opaque} SumValueSize(fields : CanonCryptoList) | ||
| function {:opaque} SumValueSize(fields : CanonCryptoList) |
There was a problem hiding this comment.
Nit: Check with the Dafny team during their office hours,
but I had great success with the hide * syntax while working on Mutations.
There was a problem hiding this comment.
I don't understand. Check with the Dafny team about what? Is something amiss here?
lucasmcdonald3
approved these changes
Apr 14, 2025
| @@ -289,7 +290,7 @@ module CompoundBeacon { | |||
| // return all the fields involved in this beacon | |||
| function method GetFields(virtualFields : VirtualFieldMap) : seq<string> | |||
| { | |||
| Seq.Flatten(Seq.Map((p : BeaconPart) => p.GetFields(virtualFields), parts)) | |||
| Sequence.Flatten(Seq.Map((p : BeaconPart) => p.GetFields(virtualFields), parts)) | |||
There was a problem hiding this comment.
(Curious) what was the performance issue with the original flatten?
There was a problem hiding this comment.
The original Flatten recurses on seq[1..], which makes a copy.
The new Flatten recurses on position+1, so no copy is made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.