Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codepipeline): add usePipelineRoleForActions field to reduce generated roles. #33926

Closed
wants to merge 0 commits into from

Conversation

hwum
Copy link
Contributor

@hwum hwum commented Mar 27, 2025

Issue # 27605

#27605

Reason for this change

Lots of customer reported they don't want such many new roles generated in cdk level.
Current cdk library will help customer to generate a action role if no role configured.
But in Codepipeline backend logic, the pipeline service role will be used as default action role, which the cdk library doesn't align.
This pr will support customer to have more alternatives and won't break anything

Description of changes

add usePipelineRoleForActions field support in L2 construct. L3 update is included in another pr

Describe any new or updated permissions being added

Yes. The build output claimed it's a destructive change. If customer to use this feature(usePipelineRoleForActions as true), it will change the logic how pipeline handle the iam.roles in pipeline. But it won't break the any current customer. So, it might be the destructive change, but it's necessary for this feature.

Description of how you validated changes

Unit test/Integ test/local deployment

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 27, 2025 03:19
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@hwum hwum requested a review from aws-cdk-automation March 27, 2025 03:22
@hwum hwum changed the title feat(codepipeline): Add usePipelineRoleForActions field to reduce number of generated roles feat(codepipeline): Add usePipelineRoleForActions field to reduce generated roles Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (519f359) to head (17a1fd3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33926   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6955     6955           
  Branches     1173     1173           
=======================================
  Hits         5730     5730           
  Misses       1120     1120           
  Partials      105      105           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hwum hwum changed the title feat(codepipeline): Add usePipelineRoleForActions field to reduce generated roles feat(codepipeline): Add usePipelineRoleForActions field to reduce generated roles. Mar 27, 2025
@hwum hwum changed the title feat(codepipeline): Add usePipelineRoleForActions field to reduce generated roles. feat(codepipeline): add usePipelineRoleForActions field to reduce generated roles. Mar 27, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 27, 2025 03:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@hwum hwum force-pushed the l2dev branch 13 times, most recently from dcf38b7 to 57f3333 Compare March 28, 2025 07:44
@hwum hwum closed this Mar 28, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 28, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 28, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e5f71db
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants