fix(core): does not generate a valid artifact id from some construct IDs

[mrgrain]

Issue

Closes #32808

Minimal reproduction:

const app = new cdk.App();
const stack = new cdk.Stack(app, 'Stack:Test', { stackName: "valid" });
assert(!stack.artifactId.match(/[^A-Za-z0-9_\-\.]/g))

Reason for this change

When users create a Stack with an id containing certain special characters, the produced artifact file name would contain invalid characters.

Description of changes

Ensure only valid artifact files names are produces, no matter the input.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

New unit tests, existing test suite

I have updated the integ test using --dry-run as per instructions in the test file.
I have deployed the integ test using the instructions in the test file.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.38%. Comparing base (3ff5501) to head (273143a).

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33863   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6938    +1     
  Branches     1170     1170           
=======================================
+ Hits         5715     5716    +1     
  Misses       1119     1119           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.38% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.38% <50.00%> (+<0.01%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #33863 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

• -label~=(blocked|do-not-merge|no-squash|two-approvers|priority-pr)
• status-success=validate-pr
• status-success~=AWS CodeBuild us-east-1
• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default-squash]
    • any of: [🛡 GitHub branch protection]
      • check-neutral = validate-pr
      • check-skipped = validate-pr
      • check-success = validate-pr
    • any of: [🛡 GitHub branch protection]
      • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
      • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
      • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 273143a
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mrgrain]

@Mergifyio requeue

[mergify]

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.