Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(applicationsignals-alpha): introduce Application Signals L2 constructs #32931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjrara
Copy link

@bjrara bjrara commented Jan 15, 2025

Issue # (if applicable)

N/A

Description of changes

This PR adds L2 constructs to simplify the Application Signals enablement process. See aws/aws-cdk-rfcs#672 for more details.

Describe any new or updated permissions being added

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2025 01:52
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@bjrara bjrara changed the title feat(aws-applicationsignals-alpha): introduce Application Signals L2 constructs feat(applicationsignals-alpha): introduce Application Signals L2 constructs Jan 15, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 15, 2025 01:56

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (35275c3) to head (344c6ee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32931   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files         226      226           
  Lines       13768    13768           
  Branches     2416     2416           
=======================================
  Hits        11219    11219           
  Misses       2271     2271           
  Partials      278      278           
Flag Coverage Δ
suite.unit 81.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.89% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@bjrara bjrara force-pushed the application-signals branch 5 times, most recently from 921a486 to 43766a8 Compare January 15, 2025 04:42
@aws aws deleted a comment from aws-cdk-automation Jan 15, 2025
@moelasmar
Copy link
Contributor

moelasmar commented Jan 16, 2025

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jan 16, 2025

refresh

✅ Pull request refreshed

@bjrara bjrara force-pushed the application-signals branch from 344c6ee to 652b1da Compare January 17, 2025 18:00
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 652b1da
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants