Fixes incorrect event being published when the meeting is ended normally #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensmi-amazon
previously approved these changes
Dec 12, 2024
|
Any public doc to update? like the the MeetingSessionStatus FAQ? https://aws.github.io/amazon-chime-sdk-js/modules/faqs.html#what-does-each-meetingsessionstatuscode-mean |
dylonChime
force-pushed
the
fix-meeting-status-event
branch
from
db4720b to
deb55ef
Compare
hensmi-amazon
previously approved these changes
Jan 7, 2025
dinmin-amzn
previously approved these changes
Jan 7, 2025
| defaultAudioClientObserver.audioClientStateChanged(AUDIO_CLIENT_STATE_RECONNECTING, | ||
| status: audio_client_status_t.init(MeetingSessionStatusCode.ok.rawValue)) | ||
| defaultAudioClientObserver.audioClientStateChanged(AUDIO_CLIENT_STATE_DISCONNECTED_ABNORMAL, | ||
| status: audio_client_status_t.init(MeetingSessionStatusCode.audioServerHungup.rawValue)) |
There was a problem hiding this comment.
nit: use a different MeetingSessionStatusCode since audioServerHungup wouldn't be returned along with AUDIO_CLIENT_STATE_DISCONNECTED_ABNORMAL
ziyiz-amzn
previously approved these changes
Jan 15, 2025
georgezy-amzn
previously approved these changes
Feb 7, 2025
dylonChime
force-pushed
the
fix-meeting-status-event
branch
from
deb55ef to
22d5fd5
Compare
dylonChime
dismissed stale reviews from dinmin-amzn, hensmi-amazon, ziyiz-amzn, and georgezy-amzn
via
5c51c80
dylonChime
force-pushed
the
fix-meeting-status-event
branch
from
22d5fd5 to
5c51c80
Compare
ziyiz-amzn
approved these changes
Feb 10, 2025
georgezy-amzn
approved these changes
Feb 10, 2025
dylonChime
force-pushed
the
fix-meeting-status-event
branch
from
5c51c80 to
ceb8929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Description
Fixes incorrect event being published when the meeting is ended normally.
Issue #, if available
Type of change
🧪 How Has This Been Tested?
describe the tests that you ran to verify your changes, any relevant details for your test configuration
Additional Manual Test
📱 Screenshots, if available
provide screenshots/video record if there's a UI change in demo app
✅ Checklist
Integration validation (required before release)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.