Updated code to support ssh into sagemaker space apps - JupyterLab #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeEditor 1. Added Dockerfile to build custom image 2. Updated script to ssh into sagemaker space apps
elishaby
changed the title
elishaby
changed the title
|
Hi, @elishaby . Thank you for your great effort in supporting the project. Your code changes gave me useful insights. I've made similar changes for the new SageMaker Studio experience in the main branch. Studio Classic is deprecated, so I left unchanged some of legacy code that you've changed in this PR, but it will be slowly updated and removed in future releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeEditor
Issue #, if available: #51
Description of changes:
Adds ssh support to space apps like CodeEditor
This PR is identical to #57, but updated to main branch
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.