Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect model reference in how_to_work_with_code_generation_w_bedrock.ipynb #496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kakakakakku
Copy link

Description of changes:

Hello, and thank you for the great content😀

While working on the "Generate Python Code with Converse" in "Gen AI Usecases," I noticed a minor issue.

In "Use case 2 - SQL query generation," the documentation states:

Let's use the Titan Text Large model:

However, the implementation actually uses the Claude v2 model, as seen in the modelId assignment:

MODEL_IDS = [
    "amazon.titan-tg1-large",
    "anthropic.claude-3-sonnet-20240229-v1:0"
]

(snip)

response = boto3_bedrock.converse(
        modelId=MODEL_IDS[1],
        messages=messages,
        inferenceConfig=inference_config
)

This Pull Request corrects the reference to the model in the documentation to align with the actual implementation.

Note

Following the guidelines in CONTRIBUTING.md, I attempted to exec the jupyter nbconvert command:

$ jupyter nbconvert --to markdown genai-use-cases/text-generation/how_to_work_with_code_generation_w_bedrock.ipynb

However, this resulted in many differences other than my intended change. To avoid unnecessary modifications, I have directly edited the markdown file instead. If I have misunderstood the correct process, please provide guidance on the best approach.

Thank you👍


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant