Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example of custom data source for bedrock kb #482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlunn4
Copy link

@jlunn4 jlunn4 commented Feb 10, 2025

Issue #, if available:

Description of changes:
I created an example showing how to use a custom data source for bedrock knowledge bases.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ssinghgai ssinghgai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any value add of this notebook for couple of reasons: 1/ How is it different from 05_document_level_kb_ingestion.ipynb notebook 2/ You are covering only one pattern of custom ingestion (i.e. Inline text) 3/Your notebook doesn't show metadata ingestion 4/ you haven't followed consistent approach of creating KB and other resources as depicted in another notebook examples i.e. using 'BedrockKnowledgeBase' classes 5/ Lack of proper documentation.

WHAT CAN WE DO: Rather just showing how to ingest a document, it would be worth to show an end-to-end example of leveraging custom data ingestion feature to ingest data from sources which aren't natively supported in KB for example: Ingest JIRA tickets into KB using custom data ingestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants