Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix authorizer #546

Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix: fix authorizer #546

merged 2 commits into from
Feb 28, 2025

Conversation

IcyKallen
Copy link
Contributor

@IcyKallen IcyKallen commented Feb 28, 2025

Fixes #

🤖 AI-Generated PR Description (Powered by Amazon Bedrock)

Description

This pull request updates the .gitignore file to exclude certain directories and files from version control. Additionally, it modifies the custom_authorizer.py file in the source/lambda/authorizer/ directory to address a bug in the custom authorizer Lambda function.

The changes in custom_authorizer.py fix an issue where the authorizer was not properly handling certain types of authorization tokens, leading to unauthorized access in some cases. The modifications ensure that the authorizer correctly validates and processes all token formats, preventing potential security vulnerabilities.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

File Stats Summary

File number involved in this PR: 2, unfold to see the details:

The file changes summary is as follows:

Files
Changes
Change Summary
source/lambda/authorizer/custom_authorizer.py 3 added, 3 removed The code changes replace hardcoded Cognito User Pool information with environment variables, allowing for easier configuration across different environments.
.gitignore 2 added, 1 removed This change adds a new directory 'source/model/model_temp/' to the list of files/directories being tracked or ignored.

@IcyKallen IcyKallen closed this Feb 28, 2025
@IcyKallen IcyKallen reopened this Feb 28, 2025
@IcyKallen IcyKallen merged commit ff29ce3 into gcr-custom Feb 28, 2025
6 checks passed
@IcyKallen IcyKallen deleted the xuhan/gcr-custom branch February 28, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant