chore: Support use of an alias field #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williazz
reviewed
Feb 19, 2025
src/dispatch/Dispatch.ts
Outdated
| @@ -224,6 +224,15 @@ export class Dispatch { | |||
| } | |||
|
|
|||
| private createRequest(): PutRumEventsRequest { | |||
| if (this.config.alias) { | |||
There was a problem hiding this comment.
Issue(small): we need to be mindful about the number of lines we add to this package. Pretty sure we can just go ahead and add Alias like this. If it's undefined, then it won't be included.
Suggested change
| if (this.config.alias) { | |
| private createRequest(): PutRumEventsRequest { | |
| return { | |
| BatchId: v4(), | |
| AppMonitorDetails: this.eventCache.getAppMonitorDetails(), | |
| UserDetails: this.eventCache.getUserDetails(), | |
| RumEvents: this.eventCache.getEventBatch(), | |
| Alias: this.config.alias | |
| }; | |
| } |
williazz
approved these changes
Feb 19, 2025
limhjgrace
approved these changes
Feb 19, 2025
|
Oh this should be a feature by the way, not a chore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the use of alias field to send with PutRumEvents request. Docs will follow in another PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.