Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing support for existing_sso_users #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

novekm
Copy link
Collaborator

@novekm novekm commented Mar 7, 2025

Fixing pipeline issues from initial PR

@novekm
Copy link
Collaborator Author

novekm commented Mar 7, 2025

Hi @artur-bolt, I moved this to a new PR as I was working to fix the pipeline errors. One was a minor one around Terraform docs that I pushed a fix for. The other failure is a functional test failure due to using a null in a for expression:

Error: �[0m�[0m�[1mIteration over null value�[0m
613 | �[31m│�[0m �[0m
614 | �[31m│�[0m �[0m�[0m  on locals.tf line 20, in locals:
615 | �[31m│�[0m �[0m  19:     for this_existing_user in keys(var.existing_sso_users) : [
616 | �[31m│�[0m �[0m  20:       for group in �[4mvar.existing_sso_users[this_existing_user].group_membership�[0m : {
617 | �[31m│�[0m �[0m  21:         user_name  = var.existing_sso_users[this_existing_user].user_name
618 | �[31m│�[0m �[0m  22:         group_name = group
619 | �[31m│�[0m �[0m  23:       }
620 | �[31m│�[0m �[0m  24:     ]�[0m
621 | �[31m│�[0m �[0m    �[90m├────────────────�[0m
622 | �[31m│�[0m �[0m�[0m    �[90m│�[0m �[1mvar.existing_sso_users�[0m is map of object with 1 element
623 | �[31m│�[0m �[0m�[0m
624 | �[31m│�[0m �[0mA null value cannot be used as the collection in a 'for' expression.
625

Can you look into this and resolve?

@novekm
Copy link
Collaborator Author

novekm commented Mar 7, 2025

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

1 similar comment
Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants