Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding trino helm as add-on #23

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

youngjeong46
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

This PR adds Trino as a data add-on. It includes helm chart and user configuration input.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@youngjeong46 youngjeong46 requested a review from a team as a code owner February 22, 2024 16:30
@youngjeong46 youngjeong46 changed the title feat: adding trino helm as add-on Feat: adding trino helm as add-on Feb 22, 2024
@youngjeong46 youngjeong46 changed the title Feat: adding trino helm as add-on feat: Adding trino helm as add-on Feb 22, 2024
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit 4e35559 into aws-ia:main Mar 16, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Trino add-on
2 participants