Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage-browser): add react-router app, add StorageBrowser examples, add @aws-amplify/ui-test-utils #6468

Open
wants to merge 3 commits into
base: feat-expose-sb-types/main
Choose a base branch
from

Conversation

calebpollman
Copy link
Member

Description of changes

  • add "@aws-amplify/ui-react-router-example" app

    • add defaultValue, legacy controlled (location, actionType and path props), and improved controlled value examples
    • add configurable react-scan perf util
  • update "@aws-amplify/ui-next-app-router-example" app

    • update name field of package,json: "@aws-amplify/ui-app-router-example" -> "@aws-amplify/ui-next-app-router-example"
    • add legacy controlled (location, actionType and path props) and improved controlled value examples
    • update react-icons dep due to failing imports
  • update "@aws-amplify/ui-next-pages-router-example" app

    • update name field of package,json: "@aws-amplify/ui-next-example" -> "@aws-amplify/ui-next-pages-router-example"
    • update react-icons dep due to failing imports
  • add @aws-amplify/ui-test-utils internal package

    • add StorageBrowser mock handlers/state
    • add eslint, typescript and rollup configs

Issue #, if available

NA

Description of how you validated changes

Manual testing

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested a review from a team as a code owner March 28, 2025 21:51
Copy link

changeset-bot bot commented Mar 28, 2025

⚠️ No Changeset found

Latest commit: 41d9ff5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


return (
<StorageBrowser
// @ts-expect-error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, put explanations after expect-error.

@@ -0,0 +1 @@
VITE_REACT_SCAN_ENABLED=TRUE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally comitted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goes question! Yes, it indicates what .env should look like for enabling react-scan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants