-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storage-browser): add react-router app, add StorageBrowser examples, add @aws-amplify/ui-test-utils #6468
base: feat-expose-sb-types/main
Are you sure you want to change the base?
Conversation
…ples, add @aws-amplify/ui-test-utils
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
||
return ( | ||
<StorageBrowser | ||
// @ts-expect-error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, put explanations after expect-error
.
@@ -0,0 +1 @@ | |||
VITE_REACT_SCAN_ENABLED=TRUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentionally comitted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goes question! Yes, it indicates what .env should look like for enabling react-scan
Description of changes
add
"@aws-amplify/ui-react-router-example"
appdefaultValue
, legacy controlled (location
,actionType
andpath
props), and improved controlledvalue
examplesreact-scan
perf utilupdate
"@aws-amplify/ui-next-app-router-example"
appname
field of package,json: "@aws-amplify/ui-app-router-example" -> "@aws-amplify/ui-next-app-router-example"location
,actionType
andpath
props) and improved controlledvalue
examplesreact-icons
dep due to failing importsupdate
"@aws-amplify/ui-next-pages-router-example"
appname
field of package,json: "@aws-amplify/ui-next-example" -> "@aws-amplify/ui-next-pages-router-example"react-icons
dep due to failing importsadd
@aws-amplify/ui-test-utils
internal packageStorageBrowser
mock handlers/stateIssue #, if available
NA
Description of how you validated changes
Manual testing
Checklist
yarn test
passes and tests are updated/addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.