-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: improve message when missing array resource for array fields #3730
Enhancement: improve message when missing array resource for array fields #3730
Conversation
Code Climate has analyzed commit ae6cd44 and detected 0 issues on this pull request. View more on Code Climate. |
Thanks for submitting this contribution @zhephyn Please ask me to review when you consider it ready to review. |
Hey @Paul-Bob. I think I've successfully implemented the enhancement as per the scope you suggested. The current failing tests indicated in the CI output seem to be beyond the scope of what we were trying to do with this PR. For example, the one below `2) Localization spec force_locale translates the resource name on the create button
Should i look into these as well? |
Hi @zhephyn
Failing tests on a PR are never beyond its scope if those same tests are passing on
I took a quick look and noticed several changes unrelated to the issue, for example, the changes on |
@Paul-Bob . Regarding how to proceed, the idea i had in mind was deleting this current branch and therefore this PR, creating a new branch locally, implementing the enhancement as per the scope, pushing it to Github and then opening a new PR. This new branch will focus solely on the scope as expected. Is this a good approach or is their perhaps a better one i could use to clean up the branch? |
Yes, @zhephyn, a new PR sounds great. Before starting a new branch, please ensure that |
Description
Enhances the thrown missing resource error such that when the field is of the type array, the error is thrown with an array flag "--flag"
Fixes # (#3713)
Checklist: