Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation in de locale for key avo.key_value_field.reorder_row #3400

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

cypher
Copy link
Contributor

@cypher cypher commented Nov 9, 2024

Description

Avo added the I18n key avo.key_value_field.reorder_row, but it did not add the corresponding key for the de locale. This is causing I18n::MissingTranslation: Translation missing: de.avo.key_value_field.reorder_row exceptions in our app.

This PR adds the missing key with a translation to the de locale.

Note: The key seems to be missing in a few other locales as well.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

n/a

Manual review steps

n/a (I think?)

Copy link

codeclimate bot commented Nov 9, 2024

Code Climate has analyzed commit 93607e8 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cypher!

@Paul-Bob Paul-Bob merged commit 68f8e3b into avo-hq:main Nov 11, 2024
18 of 21 checks passed
@Paul-Bob Paul-Bob added the Fix label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants