Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: custom list control #3218

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feature: custom list control #3218

wants to merge 10 commits into from

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Sep 4, 2024 •
edited
Loading

Description

Fixes #2784

Related PR #3218

list label: "Custom Index List", icon: "heroicons/outline/cube-transparent", style: :primary, color: :slate, title: "A custom list" do
  link_to "Google", "https://google.com", icon: "heroicons/outline/academic-cap"
  action Avo::Actions::Sub::DummyAction, icon: "heroicons/outline/globe"
  link_to "Fish.com", "https://fish.com", icon: "heroicons/outline/fire", target: :_blank
end

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob marked this pull request as draft September 4, 2024 14:27
@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 4, 2024 •
edited
Loading

Code Climate has analyzed commit 952302a and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob self-assigned this Sep 4, 2024
@Paul-Bob Paul-Bob changed the title feature: custom list feature: custom list control Sep 5, 2024
@Paul-Bob Paul-Bob marked this pull request as ready for review September 5, 2024 16:54
adrianthedev
adrianthedev reviewed Sep 6, 2024
View reviewed changes
app/components/avo/actions_component.rb
def icon(action)
svg action.icon, class: "h-5 shrink-0 mr-1 inline pointer-events-none"
def icon(icon)
svg icon, class: "h-5 shrink-0 mr-1 inline pointer-events-none"
end

def render_item(action)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole method needs a refactor at some point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I done that in this commit than reverted it =))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev adrianthedev approved these changes

@github-actions GitHub Actions github-actions left review comments

Assignees

@Paul-Bob Paul-Bob

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proper list dropdown API for controls
2 participants
@Paul-Bob @adrianthedev