[ACP-99] Emit Justification Info #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam-schultz
commented
Mar 13, 2025
cam-schultz
commented
- Adds information needed to construct ACP-118 justifications for ACP-77 ICM message types to be signed by P-Chain validators. See Emit justification info ava-labs/icm-contracts#741 for expanded context.
- Adds a missing NatSpec comment
- Formats Solidity code blocks using the stable Foundry v1.0.0 release
Comment on lines
+126
to
+127
| * This is used along with the subnetID as the ACP-118 justification for | ||
| * signature requests from P-Chain validators over a L1ValidatorRegistrationMessage |
There was a problem hiding this comment.
Suggested change
| * This is used along with the subnetID as the ACP-118 justification for | |
| * signature requests from P-Chain validators over a L1ValidatorRegistrationMessage | |
| * This is used along with the subnetID as the ACP-118 justification in | |
| * signature requests to P-Chain validators over a L1ValidatorRegistrationMessage |
It took me a few tries to parse this sentence. I think this is slightly more accurate, but feel free to disagree.
| event InitiatedValidatorRegistration( | ||
| bytes32 indexed validationID, | ||
| bytes20 indexed nodeID, | ||
| bytes32 registrationMessageID, | ||
| uint64 registrationExpiry, | ||
| uint64 weight | ||
| uint64 weight, | ||
| bytes registerL1ValidatorMessage |
There was a problem hiding this comment.
These bytes are already emitted by the precompile as part of the sendWarpMessage event here, right? Is there a significant UX improvement to also emitting them here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.