-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent circular load.properties
#178
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a simple integer instead of a set of visited resources is safer solution that will not break backward compat.
LGTM. I think we get this in before #176 |
load.properties
load.properties
@rbygrave please review when you get time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (5)
- avaje-config/src/test/resources/test-properties/chain/a.properties: Language not supported
- avaje-config/src/test/resources/test-properties/chain/b.properties: Language not supported
- avaje-config/src/test/resources/test-properties/chain/c.properties: Language not supported
- avaje-config/src/test/resources/test-properties/chain/d.properties: Language not supported
- avaje-config/src/test/resources/test-properties/chain/main.properties: Language not supported
Comments suppressed due to low confidence (1)
avaje-config/src/main/java/io/avaje/config/InitialLoader.java:212
- [nitpick] Consider replacing the hard-coded iteration limit '69' with a named constant (e.g., MAX_LOAD_ITERATIONS) to improve code clarity and maintainability.
if (sentinel == 69) {
fixes #177