Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent circular load.properties #178

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

SentryMan
Copy link
Collaborator

fixes #177

@SentryMan SentryMan requested a review from rbygrave September 25, 2024 04:35
@SentryMan SentryMan self-assigned this Sep 25, 2024
Copy link

@agentgt agentgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simple integer instead of a set of visited resources is safer solution that will not break backward compat.

@SentryMan SentryMan added the enhancement New feature or request label Sep 25, 2024
@SentryMan SentryMan added this to the 4.1 milestone Sep 25, 2024
@SentryMan SentryMan requested a review from agentgt September 26, 2024 16:54
@agentgt
Copy link

agentgt commented Sep 26, 2024

LGTM. I think we get this in before #176

@SentryMan SentryMan enabled auto-merge September 26, 2024 23:03
@SentryMan SentryMan changed the title Use a set to prevent circular load.properties Prevent circular load.properties Oct 1, 2024
@SentryMan
Copy link
Collaborator Author

@rbygrave please review when you get time

@SentryMan SentryMan mentioned this pull request Oct 28, 2024
@SentryMan SentryMan added the bug Something isn't working label Mar 21, 2025
@SentryMan SentryMan requested a review from Copilot April 7, 2025 17:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • avaje-config/src/test/resources/test-properties/chain/a.properties: Language not supported
  • avaje-config/src/test/resources/test-properties/chain/b.properties: Language not supported
  • avaje-config/src/test/resources/test-properties/chain/c.properties: Language not supported
  • avaje-config/src/test/resources/test-properties/chain/d.properties: Language not supported
  • avaje-config/src/test/resources/test-properties/chain/main.properties: Language not supported
Comments suppressed due to low confidence (1)

avaje-config/src/main/java/io/avaje/config/InitialLoader.java:212

  • [nitpick] Consider replacing the hard-coded iteration limit '69' with a named constant (e.g., MAX_LOAD_ITERATIONS) to improve code clarity and maintainability.
if (sentinel == 69) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular load.properties prevention
3 participants