Fix SimulateActions State Keys
#1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -330,7 +331,7 @@ func (j *JSONRPCServer) SimulateActions( | |||
| if err != nil { | |||
| return err | |||
| } | |||
| actionResult.StateKeys = scope.StateKeys() | |||
| actionResult.StateKeys = maps.Clone(scope.StateKeys()) | |||
There was a problem hiding this comment.
(separate from this PR) - could we add a regression test to this API?
aaronbuchwald
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug relating to the state keys being returned by the
SimulateActionsAPI method.Currently,
SimulateActionstakes in a slice of actions and executes them one-by-one, keeping track of the state key each action touches via the use ofscope:hypersdk/api/jsonrpc/server.go
Line 303 in 23fa160
After each action is executed, the state keys that it touched are stored in its respective result and the for-loop moves on to the next action. Before moving onto the next iteration,
scopeis cleared. Since the underlying type ofstate.SimulatedKeysis a map (and therefore, a pointer), the recorded state keys of all previous actions is wiped, which should not be the case.This PR fixes the bug above by using
maps.Cloneto copy the KV-pairs ofscopeinto the actions recorded state keys.