Upgrade avalanchego dependency #1901
Merged
+135
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…va-labs/hypersdk into tsachi/configurable-chunk-rate-limiter
…ava-labs/hypersdk into tsachi/configurable-chunk-rate-limiter2
…ava-labs/hypersdk into tsachi/configurable-chunk-rate-limiter2
tsachiherman
changed the title
tsachiherman
requested review from
aaronbuchwald and
joshua-kim
as code owners
x/dsmr/certificate.go
Outdated
| @@ -89,13 +89,11 @@ func (c *ChunkCertificate) Verify( | |||
| if err != nil { | |||
| return fmt.Errorf("failed to initialize unsigned warp message: %w", err) | |||
| } | |||
|
|
|||
| vs, _ := warp.GetCanonicalValidatorSetFromChainID(ctx, pChainState, pChainHeight, msg.SourceChainID) | |||
There was a problem hiding this comment.
Can we check the error value here?
x/dsmr/node.go
Outdated
Comment on lines
457
to
462
| func (pChain) GetCurrentValidatorSet( | ||
| context.Context, | ||
| ids.ID, | ||
| ) (map[ids.ID]*snowValidators.GetCurrentValidatorOutput, uint64, error) { | ||
| return nil, 0, nil | ||
| } |
There was a problem hiding this comment.
why does this return empty?
There was a problem hiding this comment.
The method is currently not being used. I'll add an error here to indicate that.
( it will be removed in my subsequent PR ).
x/dsmr/certificate.go
Outdated
| @@ -89,13 +89,14 @@ func (c *ChunkCertificate) Verify( | |||
| if err != nil { | |||
| return fmt.Errorf("failed to initialize unsigned warp message: %w", err) | |||
| } | |||
|
|
|||
| vs, err := warp.GetCanonicalValidatorSetFromChainID(ctx, pChainState, pChainHeight, msg.SourceChainID) | |||
There was a problem hiding this comment.
Can we use a more descriptive variable name here, perhaps canonicalValidatorSet ?
aaronbuchwald
previously approved these changes
Feb 3, 2025
aaronbuchwald
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
Update the avalanchego with the latest changes.
Include few fixes for the e2e testing, and in particular, avoid caching the URIs to prevent stale URIs.