Skip to content

make URI,StakingAddress to be empty when reading a tmpnet after a kill -9 of the processes #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

make URI,StakingAddress to be empty when reading a tmpnet after a kill -9 of the processes #2741

wants to merge 2 commits into from
+29 −1

Conversation

felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented Apr 15, 2025 •
edited
Loading

Why this should be merged

Closes #2738

pkg/localnet/tmpnet.go currently assumes that when reading a tmpnet, the node fields URI, StakingAddress
will be empty if the associated nodes are not up. This is found to not be true after killing the processes with
SIGKILL.
This PR fixes this issue by adding code to fix the network metadata based on process state

How this works

How this was tested

Two cases.

Trying to stop a network with killed nodes was failling (Ref #2738)

network start
killall -9 avalanchego
network stop

Truing to start a network with killed nodes was failling

network start
killall -9 avalanchego
network start
  • CI

How is this documented

@felipemadero felipemadero requested a review from a team as a code owner April 15, 2025 13:57
@felipemadero felipemadero mentioned this pull request Apr 15, 2025
Open
@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to In Review 👀 in Platform Engineering Group Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tonix517 Tonix517 Tonix517 approved these changes

@learyce learyce Awaiting requested review from learyce learyce is a code owner automatically assigned from ava-labs/tooling

@jasonatran jasonatran Awaiting requested review from jasonatran jasonatran is a code owner automatically assigned from ava-labs/tooling

@sukantoraymond sukantoraymond Awaiting requested review from sukantoraymond sukantoraymond is a code owner automatically assigned from ava-labs/tooling

@artemanosov artemanosov Awaiting requested review from artemanosov artemanosov is a code owner automatically assigned from ava-labs/tooling

@meaghanfitzgerald meaghanfitzgerald Awaiting requested review from meaghanfitzgerald meaghanfitzgerald is a code owner automatically assigned from ava-labs/tooling

@cwend-ava cwend-ava Awaiting requested review from cwend-ava cwend-ava is a code owner automatically assigned from ava-labs/tooling

Assignees

@felipemadero felipemadero

Labels
None yet
Projects
Platform Engineering Group
Status: In Review 👀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: The local subnet configuration was not saved after restarting
2 participants
@felipemadero @Tonix517