fix: install script location default & parsing #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sets default location to `~/.local/bin` (standard location on Linux, macOS, etc) - removes trailing slash from install path (prevents cases like `install.sh -b /usr/local/bin/` producing `ava-labs/avalanche-cli info installed /usr/local/bin//avalanche`) Signed-off-by: Kainoa Kanter <[email protected]>
ThatOneCalculator
requested review from
learyce,
jasonatran,
sukantoraymond,
meaghanfitzgerald and
cwend-ava
ThatOneCalculator
changed the title
this is a non-standard location and will not be recognized in $PATH on pretty much any machine, but is kept here for backwards compatibility and *apparently* being 'easy to remember or locate'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Sets default location to
~/.local/bin(standard location on Linux, macOS, etc)Removes trailing slash from install path (prevents cases like
install.sh -b /usr/local/bin/producingava-labs/avalanche-cli info installed /usr/local/bin//avalanche)How this works
BINDIRto itself but with trailing slash removed if it existsBINDIRto default (~/.local/bin) if it's an empty stringHow this was tested
How is this documented