Refactor node setup out of node create #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this conflict with #2337? Should 2337 be closed? |
meaghanfitzgerald
added this to the Separate Node Provisioning from Node Infrastructure Creation milestone
arturrez
reviewed
Jan 24, 2025
arturrez
reviewed
Jan 24, 2025
arturrez
reviewed
Jan 24, 2025
arturrez
reviewed
Jan 28, 2025
arturrez
approved these changes
Jan 28, 2025
Signed-off-by: sukantoraymond <[email protected]>
felipemadero
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor node setup out of
node create, specifically the setup() function.Node createis now node provisioning on AWS / GCP, followed by setup().Adds a new node command,
node setup, which installs Avalanche-CLI issued Ubuntu AMI on ubuntu based servers. This command requires the server's IP address and ssh private key. It also requires the server to have allowed access to port 22 to machine that is callingnode setupcommand. Thenode setupcommand is essentially calling setup() function.