-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multi_object_tracker): add diagnostics warning when extrapolation time exceeds limit with latency guarantee enabled #10301
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10301 +/- ##
==========================================
- Coverage 26.04% 26.01% -0.03%
==========================================
Files 1375 1375
Lines 106439 106559 +120
Branches 40902 40950 +48
==========================================
Hits 27726 27726
- Misses 76009 76129 +120
Partials 2704 2704
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elapsed_time
is time interval of each publish.
In the title, extrapolation is the target of diagnostics, but the implementation is not.
To know how long the tracker is extrapolated,
autoware_universe/perception/autoware_multi_object_tracker/lib/tracker/model/vehicle_tracker.cpp
Line 282 in b13520d
if (!motion_model_.getPredictedState(time, pose, pose_cov, twist, twist_cov)) { |
motion_model_.getPredictedState(time, pose, pose_cov, twist, twist_cov)
need to know how the given time is away from the tracker time.
All of the tracker may have different last_update_with_measurement_time_
, therefore the extrapolation length is also different.
As a total diagnostics, we may want to know if the shortest extrapolation is too long or not.
I would like to request change of the diagnostics logic.
198a546
to
4a6804f
Compare
…n time exceeds limit with latency guarantee enabled Signed-off-by: lei.gu <[email protected]>
b8dc9b9
to
c729ab9
Compare
Description
Related links
Parent Issue:
How was this PR tested?
Tested by running logging simulator
OK:

Warnings:

Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.