Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): add diagnostics warning when extrapolation time exceeds limit with latency guarantee enabled #10301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ogrex
Copy link

@ogrex ogrex commented Mar 19, 2025

Description

Related links

Parent Issue:

  • Link

How was this PR tested?

Tested by running logging simulator

OK:
image

Warnings:
image

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 19, 2025
Copy link

github-actions bot commented Mar 19, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ogrex ogrex marked this pull request as ready for review March 19, 2025 08:05
@technolojin technolojin self-assigned this Mar 24, 2025
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 26.01%. Comparing base (e69b61d) to head (c729ab9).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
...i_object_tracker/src/multi_object_tracker_node.cpp 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10301      +/-   ##
==========================================
- Coverage   26.04%   26.01%   -0.03%     
==========================================
  Files        1375     1375              
  Lines      106439   106559     +120     
  Branches    40902    40950      +48     
==========================================
  Hits        27726    27726              
- Misses      76009    76129     +120     
  Partials     2704     2704              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.04% <ø> (∅) Carriedforward from e69b61d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elapsed_time is time interval of each publish.

In the title, extrapolation is the target of diagnostics, but the implementation is not.

To know how long the tracker is extrapolated,

if (!motion_model_.getPredictedState(time, pose, pose_cov, twist, twist_cov)) {

motion_model_.getPredictedState(time, pose, pose_cov, twist, twist_cov)

need to know how the given time is away from the tracker time.

All of the tracker may have different last_update_with_measurement_time_, therefore the extrapolation length is also different.
As a total diagnostics, we may want to know if the shortest extrapolation is too long or not.

I would like to request change of the diagnostics logic.

@ogrex ogrex force-pushed the feat/multi_object_tracker/add_diag branch from 198a546 to 4a6804f Compare March 27, 2025 08:44
…n time exceeds limit with latency guarantee enabled

Signed-off-by: lei.gu <[email protected]>
@ogrex ogrex force-pushed the feat/multi_object_tracker/add_diag branch from b8dc9b9 to c729ab9 Compare March 27, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants