feat: address_format_update #1107
Conversation
❌ Deploy Preview for dev-astral failed. Why did it fail? →
|
There was a problem hiding this comment.
Thank you for your contribution @varunguleriaCodes 🙇♂️
I left a few notes and changes request 👍
| @@ -130,7 +146,7 @@ export const AccountList: FC = () => { | |||
| ).toString() | |||
| } | |||
| } | |||
|
|
|||
| setUpdatedFilters(tempUpdatedFilters); | |||
There was a problem hiding this comment.
The goal of a useMemo, is to be a pure function and memorize the values, to prevent re-rendering. By setting a state inside the useMemo we lose the purpose of the memoization
| @@ -256,6 +272,12 @@ export const AccountList: FC = () => { | |||
| setIsVisible(inView) | |||
| }, [inView, setIsVisible]) | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
I don't believe we need this useEffect to achieve what we want
There was a problem hiding this comment.
Hi @marc-aurele-besner , I am unable to find a way to bypass this can you give some hint about how should I try this
There was a problem hiding this comment.
So I'm not expecting you to update the searchValue, but rather to simply convert the search value to the right address format if the search value is a valid address
There was a problem hiding this comment.
I realized the address I provided as example did not had any entry in mainnet and testnet (it was a address use on 3g or 3h only) so one way to convert any address to the st is to go on a address detail page, then in utils/formatAddress line 6 change SUBSPACE_ACC_PREFIX for 2254
Fixes #1065
On entering the test case it converts it to the address mentioned in image
