-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add addressFormat support on various search by account #1065
Comments
Hi @marc-aurele-besner I will like to work on this can you provide some more details regarding this, thanks |
This was an improvement that was suggested/reported in the general-chat of our Discord. To give more context, on previous testnet version, we used addresses starting with "st" and some farmer may have keep their farmer pointing to st addresses. This is not an issue since st address resolve to a su addresses and if searching for a st address in the home search bar or directly in the account's url pathname. It will resolve to the right su address details page. The only place where I see this conversion is not supported, is in the advance table search and filtering options.
astral/explorer/src/components/Consensus/Account/AccountList.tsx Lines 67 to 76 in 653ff72
The function that convert an address to the su format is in utils/formatAddress The main issue I see, however, is that currently the search logic also handle partial address because of the ilike, if we move format the address before doing the search, it will result in error on partial address... (To be honest when I first created this issue, it was just for tracking purposes, I had not investigated it, I thought the issue was on the search bar on the home screen, but I now see that the home screen search bar does handle st address) Here is a st address that can be used for testing |
Hi @marc-aurele-besner I think of implementing something like this:
What do you think about this? |
That make sense 💪 |
Add addressFormat support on various search by account
The text was updated successfully, but these errors were encountered: