Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing fields to LogEntry (#766) #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mohsens22
Copy link

Changes

Addition of a few properties returned by Auth0 Management API's
api/v2/logs endpoint which are present in the response body and documented in Auth0 docs but they are missing in the SDK.

References

Testing

By calling the management API with the new class, the additional properties will be populated.

Checklist

@Mohsens22 Mohsens22 requested a review from a team as a code owner January 16, 2025 17:00
@Mohsens22 Mohsens22 changed the title Added missing fields to LogEntry (766) Added missing fields to LogEntry (#766) Jan 16, 2025
@kailash-b
Copy link
Contributor

Hi @Mohsens22
Thanks for the effort.
While most part of the changes look okay, I do not see the tenant_name and client_ip fields documented in the API.
I will check if this is intended or a miss and update this thread.

In the meanwhile, can you please verify your commit?
You could follow the instructions here.
This has been a recent change and we are updating our ReadMe (contribution guidelines) to include this pre-requisite.

@Mohsens22
Copy link
Author

@kailash-b This is an example of what we get when doing the call

[
  {
    "date": "2025-01-16T14:31:08.952Z",
    "type": "seccft",
    "description": "",
    "connection_id": "",
    "client_id": "cxxxxxxxxxxxxxxxxxxxxxxxc",
    "client_name": "API Explorer Application",
    "ip": "54.1.1.1",
    "client_ip": "54.1.1.1",
    "hostname": "some-thing.eu.auth0.com",
    "user_id": "",
    "user_name": "",
    "audience": "https://some-thing.eu.auth0.com/api/v2/",
    "scope": "read:some_thing",
    "$event_schema": {
      "version": "1.0.0"
    },
    "log_id": "9002025011614310899230500000000000000100000000000000000",
    "tenant_name": "some-thing",
    "_id": "9002025011614310899230500000000000000100000000000000000",
    "isMobile": false,
    "user_agent": "Other 0.0.0 / Other 0.0.0"
  }
]

@Mohsens22 Mohsens22 force-pushed the Fix/766MissingLogEntryProperties branch from 0c3ef1e to ff3c970 Compare January 17, 2025 15:23
@Mohsens22
Copy link
Author

@kailash-b The commit is now verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants