Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error in using grid search file #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix: Error in using grid search file
TypeError: Cannot read property 'rng' of undefined
    at GridSearch.BaseSpace.eval (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:282:23)      
    at /mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:1093:25
    at Array.forEach (<anonymous>)
    at gridSearch (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:1092:10)
    at FMinIter.<anonymous> (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:679:28)
    at Generator.next (<anonymous>)
    at step (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:17:30)
    at /mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:35:14
    at new Promise (<anonymous>)
    at FMinIter.<anonymous> (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:14:12)
    at FMinIter.run (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:704:20)
    at FMinIter.<anonymous> (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:710:17)
    at Generator.next (<anonymous>)
    at step (/mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:17:30)
    at /mnt/c/Users/sony/Downloads/pics/projects/refuture/node_modules/hyperparameters/lib/hyperparameters.js:35:14
    at new Promise (<anonymous>)
ifeLight authored Sep 18, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit c6646b6f865eac7e9a339d0d2f1220280e063e18
2 changes: 1 addition & 1 deletion src/search/grid.js
Original file line number Diff line number Diff line change
@@ -112,7 +112,7 @@ export const gridSearch = (newIds, domain, trials) => {
let rval = [];
const gs = new GridSearch();
newIds.forEach((newId) => {
const paramsEval = gs.eval(domain.expr);
const paramsEval = gs.eval(domain.expr, {rng: undefined});
const result = domain.newResult();
rval = [...rval, ...trials.newTrialDocs([newId], [result], [paramsEval])];
});