ENH: add support for pathlib.Path inputs in import_file #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
enh/support_pathlib.Path_import_file
branch
from
e8898d4
to
e32444a
Compare
|
See #84 - shall we close this and keep that one? (I have included tests etc) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 76.06% 75.98% -0.08%
==========================================
Files 4 4
Lines 330 329 -1
==========================================
- Hits 251 250 -1
Misses 79 79 ☔ View full report in Codecov by Sentry. |
neutrinoceros
force-pushed
the
enh/support_pathlib.Path_import_file
branch
from
e32444a
to
7ab91a5
Compare
|
Closing in favour of #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in https://github.com/astropy/astropy/pull/16936/files#r1744343515