DEPR: deprecate 'clobber' alias for overwrite keyword argument #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
depr/deprecate_clobber_kwarg
branch
from
1ddb107
to
af5d0e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 97.55% 97.62% +0.06%
==========================================
Files 9 9
Lines 1392 1388 -4
==========================================
- Hits 1358 1355 -3
+ Misses 34 33 -1 ☔ View full report in Codecov by Sentry. |
neutrinoceros
force-pushed
the
depr/deprecate_clobber_kwarg
branch
from
af5d0e9
to
c27a775
Compare
😬 there is some "vintage" code in there....thanks for catching this! |
mwcraig
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the package, I stumbled upon a
_ASTROPY_LT_1_3constant so I pulled the thread.