Allow virtual packages with --no-build
#12314
Merged
+157
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/v
branch
2 times, most recently
from
292148d to
0442431
Compare
charliermarsh
commented
Mar 19, 2025
| } | ||
|
|
||
| #[test] | ||
| fn virtual_no_build_dynamic_cached() -> Result<()> { |
There was a problem hiding this comment.
Super confusing that this test succeeds but the next test fails. The difference is that in this test, the dynamic metadata is cached, so we don't need to run any Python.
charliermarsh
force-pushed
the
charlie/v
branch
from
0442431 to
d84dfea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12311.