Continue on client errors when fetching wheel metadata #12255
+146
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/continue
branch
from
32051df to
44398b1
Compare
charliermarsh
added
the
enhancement
charliermarsh
force-pushed
the
charlie/continue
branch
from
44398b1 to
9a6c07b
Compare
konstin
approved these changes
Mar 18, 2025
|
I need to see what this looks like when you fail to authenticate with all wheels for a given server. |
|
Can we make this an opt-in setting per index? I'm not sure what to call it yet. |
|
Oh no, a name... |
paveldikov
reviewed
Mar 20, 2025
| hint: Pre-releases are available for `anyio` in the requested range (e.g., 4.0.0rc1), but pre-releases weren't enabled (try: `--prerelease=allow`) | ||
|
|
||
| hint: Metadata for `anyio` (v4.3.0) could not be fetched; the server returned: `401 Unauthorized` | ||
| help: If you want to add the package regardless of the failed resolution, provide the `--frozen` flag to skip locking and syncing. |
There was a problem hiding this comment.
Ooooh, this is terrific. That error message by itself is quite a potent troubleshooting aide.
There was a problem hiding this comment.
P.S. if this test case were cloned with --prerelease=allow, it should succeed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows the resolver to continue (backtrack) when wheel metadata fetches fail due to a client error (like a 403). We may want this to be opt-in?
Closes #5260.
If all distributions can't be fetched, you get something like this: