Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Add missing imports in mdtests #15869

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

dhruvmanila
Copy link
Member

Summary

Related to #15848, this PR adds the imports explicitly as we'll now flag these symbols as undefined.

@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Feb 1, 2025
@dhruvmanila dhruvmanila force-pushed the dhruv/add-missing-imports branch from 762e315 to 6a2f1a8 Compare February 1, 2025 10:27
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to split this change into its own PR!

@dhruvmanila dhruvmanila enabled auto-merge (squash) February 3, 2025 09:21
@dhruvmanila dhruvmanila merged commit d082c1b into main Feb 3, 2025
21 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/add-missing-imports branch February 3, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants