Update macOS notarization to use notarytool #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into the libbrotli already signed issue in the Qt upgrade branch. I think homebrew must have started signing stuff that it installs or something and so we need to remove the signature in order to allow us to sign it. You can see the fix in |
|
Sorry, you need to take just that one line and unmerge the rest of this. There are other problems that that branch introduces that are less trivial to fix. |
jkennedyvz
force-pushed
the
jkennedyvz/update-notarytool
branch
3 times, most recently
from
066ca48 to
3d9ccc9
Compare
jkennedyvz
force-pushed
the
jkennedyvz/update-notarytool
branch
from
3d9ccc9 to
2df4fb3
Compare
|
Everything seems to work now! |
jrozner
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #251
Updates the CI pipeline to use
notarytoolfor macOS notarization and removes references toGon.Gonfor macOS notarization in the.github/workflows/ci.yamlfile.notarytool, prepare the application for notarization, submit it for notarization, and staple the notarization ticket to the application in the macOS build steps.For more details, open the Copilot Workspace session.