Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-build to origin branch correctly #420

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Mar 27, 2025

Currently, asdf cmd nodejs update-nodebuild is broken.
It only git checkout the local branch, but never updates to the origin branch correctly. We should fast-forward after fetch and checkout.

@Stratus3D
Copy link
Member

@augustobmoura can you review this one? I don't know that this change is needed.

@augustobmoura
Copy link
Member

That's a good catch @harryzcy!
I changed some code around to fix another problem and forgot to add the merge command

Thank you for the contribution!

@augustobmoura augustobmoura merged commit fd2c7f9 into asdf-vm:master Mar 27, 2025
2 checks passed
@harryzcy harryzcy deleted the nodebuild-update-origin branch March 28, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants