add support for optional secrets using flag optional-secrets #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arttor! It took me a while, but I found time to push this PR. What do you think? Does it suit the project scope? Does it lack anything? |
arttor
requested changes
Nov 28, 2024
There was a problem hiding this comment.
hi, thank you for this proposal.
Can you please explain how optional secrets will be used?
I am asking only because i had different understanig based on our disucssion in #152.
My understanding was that:
- User provides list of secret names as flag. These secrets should be created externally and not be a part of Helm chart.
- Helmify will ignore listed secrets entirely and will not create any templates for these secrets
- Helmify will find secret usages in other resoruces like Pod and replace it with a name of external secret, which will be stored in
values.yamlasexternalSecrets: <secret_name>: "<secret_name>"
|
Hi @arttor what do you think? Can this be merged? |
|
sorry for not responding. But i am a bit struggling to understand the feature by looking at the code. Can you please explain what it does and what is the use-case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for optional secrets which are not required by default.
related to #152