Fix out of bounds for some ref URLs

arp242 · May 16, 2023 · f808c45 · f808c45
1 parent 6d1c961
commit f808c45
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/hit_test.go b/hit_test.go
@@ -60,6 +60,8 @@ func TestHitDefaultsRef(t *testing.T) {
 		{"https://np.reddit.com/r/programming/.compact", "www.reddit.com/r/programming", nil, set, "h"},
 
 		{"android-app://com.example.android", "com.example.android", nil, nil, "o"},
+
+		{"/?fbclid=PAAaa9RPz6YNKOc1LT4OzcjmuQpMiQl214kJ5YluqNF77eDp8JZQJOazM_GQc", "", nil, nil, "o"},
 	}
 
 	ctx := gctest.DB(t)

diff --git a/ref.go b/ref.go
@@ -183,10 +183,11 @@ func cleanRefURL(ref string, refURL *url.URL) (string, bool) {
 	q.Del("__cf_chl_captcha_tk__") // Cloudflare
 	q.Del("__cf_chl_jschl_tk__")
 
-	if len(q) == 0 {
-		return refURL.String()[2:], false
+	s := refURL.String()
+	if len(s) > 1 {
+		return s[2:], false
 	}
-	return refURL.String()[2:], false
+	return "/", false
 }
 
 // ListRefsByPath lists all references for a pathID.