Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable casing #91

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Jan 13, 2025

nph would not compile under Nim 2.0.14 because casing of the variable names does not match declaration.

@arnetheduck
Copy link
Owner

arnetheduck commented Jan 15, 2025

nph compiles fine with 2.0.14 but what you've likely done is adding the --stylecheck:error flag when trying to compile (it is not on by default in nim).

For this higher level of case correctness to be maintained, this PR should add the stylecheck flag to nph's own CI as well, probably via config.nims, or there will be regressions.

@AuHau
Copy link
Contributor Author

AuHau commented Jan 15, 2025

nph compiles fine with 2.0.14 but what you've likely done is adding the --stylecheck:error flag when trying to compile (it is not on by default in nim).

Oh pardon my ignorance then 😅

For this higher level of case correctness to be maintained, this PR should add the stylecheck flag to nph's own CI as well, probably via config.nims, or there will be regressions.

Will do, thanks for the pointer!

@AuHau
Copy link
Contributor Author

AuHau commented Jan 15, 2025

@arnetheduck done.

@arnetheduck arnetheduck merged commit 43cb1a4 into arnetheduck:master Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants