Fix cmake syntax in generate_version_txt.cmake. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 23f1d75 included `$(LLVM_TOOLCHAIN_C_LIBRARY)`, which isn't valid cmake syntax – to interpolate a cmake variable you have to use braces, not parentheses. This led to a mysterious error from git fatal: cannot change to 'rev-parse': No such file or directory because once `${base_library}` is set to something that doesn't make sense, `git -C ${${base_library}_SOURCE_DIR} rev-parse HEAD` substitutes nothing at all for the source directory, and the command collapses to just `git -C rev-parse` which indeed interprets `rev-parse` as the directory to change into.
pratlucas
pushed a commit
to pratlucas/arm-toolchain
that referenced
this pull request
Feb 28, 2025
Commit 23f1d75 included `$(LLVM_TOOLCHAIN_C_LIBRARY)`, which isn't valid cmake syntax – to interpolate a cmake variable you have to use braces, not parentheses. This led to a mysterious error from git fatal: cannot change to 'rev-parse': No such file or directory because once `${base_library}` is set to something that doesn't make sense, `git -C ${${base_library}_SOURCE_DIR} rev-parse HEAD` substitutes nothing at all for the source directory, and the command collapses to just `git -C rev-parse` which indeed interprets `rev-parse` as the directory to change into.
pratlucas
pushed a commit
that referenced
this pull request
Feb 28, 2025
Commit 23f1d75 included `$(LLVM_TOOLCHAIN_C_LIBRARY)`, which isn't valid cmake syntax – to interpolate a cmake variable you have to use braces, not parentheses. This led to a mysterious error from git fatal: cannot change to 'rev-parse': No such file or directory because once `${base_library}` is set to something that doesn't make sense, `git -C ${${base_library}_SOURCE_DIR} rev-parse HEAD` substitutes nothing at all for the source directory, and the command collapses to just `git -C rev-parse` which indeed interprets `rev-parse` as the directory to change into.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 23f1d75 included
$(LLVM_TOOLCHAIN_C_LIBRARY), which isn't valid cmake syntax – to interpolate a cmake variable you have to use braces, not parentheses.This led to a mysterious error from git
fatal: cannot change to 'rev-parse': No such file or directory
because once
${base_library}is set to something that doesn't make sense,git -C ${${base_library}_SOURCE_DIR} rev-parse HEADsubstitutes nothing at all for the source directory, and the command collapses to justgit -C rev-parsewhich indeed interpretsrev-parseas the directory to change into.