[llvmlibc] Enable FP printf, using the new float320 code. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new option `LIBC_CONF_PRINTF_FLOAT_TO_STR_USE_FLOAT320` enables a strategy for floating-point printf which is both smaller and faster than the existing `USE_DYADIC_FLOAT`, and _much_ smaller than any version using a precomputed table of Ryū coefficients. I think it's reasonable to enable it in our llvm-libc builds. Also updated the llvmlibc sample application, which was previously using a trick with `lround` to retrieve the first 6 digits of pi, precisely because FP printf wasn't available. Now that it is, it makes the sample program more comprehensible if we just use it!
|
This depends on llvm/llvm-project#125864 in order to build successfully, due to our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option
LIBC_CONF_PRINTF_FLOAT_TO_STR_USE_FLOAT320enables a strategy for floating-point printf which is both smaller and faster than the existingUSE_DYADIC_FLOAT, and much smaller than any version using a precomputed table of Ryū coefficients. I think it's reasonable to enable it in our llvm-libc builds.Also updated the llvmlibc sample application, which was previously using a trick with
lroundto retrieve the first 6 digits of pi, precisely because FP printf wasn't available. Now that it is, it makes the sample program more comprehensible if we just use it!