Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain the old return code when executing the bash_prompt changes. #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gerph
Copy link

@gerph gerph commented Jun 19, 2018

The 'bash_prompt' function was not preserving the return code between
calls to it. If other PROMPT_COMMAND executions were to rely on the
return code - say, to change the value of a variable that would be
substituted into the PS1 value to indicate the return code - this
would be broken, causing such functions to break.

This change preserves the return code such that the subsequent prompt
command executions can take advantage of the value of the prior
executed commands return.

The 'bash_prompt' function was not preserving the return code between
calls to it. If other PROMPT_COMMAND executions were to rely on the
return code - say, to change the value of a variable that would be
substituted into the PS1 value to indicate the return code - this
would be broken, causing such functions to break.

This change preserves the return code such that the subsequent prompt
command executions can take advantage of the value of the prior
executed commands return.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant