Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for databases enforcing strict data integrity through PKs. Fixes #13611 #14103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add support for databases enforcing strict data integrity through PKs. Fixes #13611 #14103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f7b1fc
feat: add support for databases enforcing strict data integrity throu…
radusora Jan 20, 2025
64a927a
Merge branch 'main' into add-schema-history-pk
radusora Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions persist/sqldb/migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,43 @@ func ternary(condition bool, left, right change) change {
}

func (m migrate) Exec(ctx context.Context) (err error) {

dbType := dbTypeFor(m.session)

{
// poor mans SQL migration
_, err = m.session.SQL().Exec("create table if not exists schema_history(schema_version int not null)")
_, err = m.session.SQL().Exec("create table if not exists schema_history(schema_version int not null, primary key(schema_version))")
if err != nil {
return err
}

// Ensure the schema_history table has a primary key, creating it if necessary
// This logic is implemented separately from regular migrations to improve compatibility with databases running in strict or HA modes
dbIdentifierColumn := "table_schema"
if dbType == Postgres {
dbIdentifierColumn = "table_catalog"
}
rows, err := m.session.SQL().Query(
"select 1 from information_schema.table_constraints where constraint_type = 'PRIMARY KEY' and table_name = 'schema_history' and "+dbIdentifierColumn+" = ?",
m.session.Name())
if err != nil {
return err
}
defer func() {
tmpErr := rows.Close()
if err == nil {
err = tmpErr
}
}()
if !rows.Next() {
_, err := m.session.SQL().Exec("alter table schema_history add primary key(schema_version)")
if err != nil {
return err
}
} else if err := rows.Err(); err != nil {
return err
}

rs, err := m.session.SQL().Query("select schema_version from schema_history")
if err != nil {
return err
Expand All @@ -65,7 +96,6 @@ func (m migrate) Exec(ctx context.Context) (err error) {
return err
}
}
dbType := dbTypeFor(m.session)

log.WithFields(log.Fields{"clusterName": m.clusterName, "dbType": dbType}).Info("Migrating database schema")

Expand Down